[
https://issues.apache.org/jira/browse/YARN-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509158#comment-14509158
]
Jason Lowe commented on YARN-3537:
----------------------------------
The code checks for a null store to avoid invoking the stop method, but then a
few lines later it has the potential to invoke the canRecover method. Seems
like we want to avoid doing anything at all in this method if the store is null.
> NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked
> --------------------------------------------------------------------
>
> Key: YARN-3537
> URL: https://issues.apache.org/jira/browse/YARN-3537
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.7.0
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: YARN-3537.patch
>
>
> 2015-04-23 19:30:34,961 INFO [main] service.AbstractService
> (AbstractService.java:noteFailure(272)) - Service NodeManager failed in state
> STOPPED; cause: java.lang.NullPointerException
> java.lang.NullPointerException
> at
> org.apache.hadoop.yarn.server.nodemanager.NodeManager.stopRecoveryStore(NodeManager.java:181)
> at
> org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceStop(NodeManager.java:326)
> at
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> at
> org.apache.hadoop.yarn.server.nodemanager.TestNodeManagerShutdown.tearDown(TestNodeManagerShutdown.java:106)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
