[ https://issues.apache.org/jira/browse/YARN-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509303#comment-14509303 ]
Jason Lowe commented on YARN-3537: ---------------------------------- If the store is not null then we want to close it regardless of whether the context is null or not, because that means we opened it earlier. My previous point is that if we don't have a store then this method has nothing to do. If the context is null but the store isn't then there _is_ something that still needs to be done. > NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked > -------------------------------------------------------------------- > > Key: YARN-3537 > URL: https://issues.apache.org/jira/browse/YARN-3537 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.7.0 > Reporter: Brahma Reddy Battula > Assignee: Brahma Reddy Battula > Attachments: YARN-3537-002.patch, YARN-3537.patch > > > 2015-04-23 19:30:34,961 INFO [main] service.AbstractService > (AbstractService.java:noteFailure(272)) - Service NodeManager failed in state > STOPPED; cause: java.lang.NullPointerException > java.lang.NullPointerException > at > org.apache.hadoop.yarn.server.nodemanager.NodeManager.stopRecoveryStore(NodeManager.java:181) > at > org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceStop(NodeManager.java:326) > at > org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221) > at > org.apache.hadoop.yarn.server.nodemanager.TestNodeManagerShutdown.tearDown(TestNodeManagerShutdown.java:106) -- This message was sent by Atlassian JIRA (v6.3.4#6332)