Sangjin Lee commented on YARN-3390:

Thanks [~gtCarrera9] for reminding me of this. You mentioned this in another 
JIRA but I couldn't find it.

Then v.3 does have the same issue in that collector.init() and 
collector.start() are done after the lock is released. Then I think we should 
go back to the previous version on this (collector.init() and collector.start() 
should be done inside the synchronization block so that no other thread can 
start using it before those operations are done).

Could we make that one revision? Then I think we're good to go.

> Reuse TimelineCollectorManager for RM
> -------------------------------------
>                 Key: YARN-3390
>                 URL: https://issues.apache.org/jira/browse/YARN-3390
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3390.1.patch, YARN-3390.2.patch, YARN-3390.3.patch
> RMTimelineCollector should have the context info of each app whose entity  
> has been put

This message was sent by Atlassian JIRA

Reply via email to