[
https://issues.apache.org/jira/browse/YARN-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510044#comment-14510044
]
Li Lu commented on YARN-3390:
-----------------------------
Hi [~zjshen], the latest patch looks good to me. Just one note is that we need
to be careful when overriding the {{postRemove}} method. Since it's in a
synchronized block, having a long postRemove method may significantly blocks
the critical section.
I'm OK with all the rationales about the unfixed comments.
> Reuse TimelineCollectorManager for RM
> -------------------------------------
>
> Key: YARN-3390
> URL: https://issues.apache.org/jira/browse/YARN-3390
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: YARN-3390.1.patch, YARN-3390.2.patch
>
>
> RMTimelineCollector should have the context info of each app whose entity
> has been put
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
