[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535582#comment-14535582
 ] 

Hadoop QA commented on YARN-3018:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m  6s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 46s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 48s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 47s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 15s | The patch does not introduce 
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests |  52m 17s | Tests passed in 
hadoop-yarn-server-resourcemanager. |
| | |  89m 34s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12731172/YARN-3018-5.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 8f7c236 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/7821/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/7821/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/7821/console |


This message was automatically generated.

> Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
> code and default xml file
> ----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3018
>                 URL: https://issues.apache.org/jira/browse/YARN-3018
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>            Reporter: nijel
>            Assignee: nijel
>            Priority: Trivial
>         Attachments: YARN-3018-1.patch, YARN-3018-2.patch, YARN-3018-3.patch, 
> YARN-3018-4.patch, YARN-3018-5.patch
>
>
> For the configuration item "yarn.scheduler.capacity.node-locality-delay" the 
> default value given in code is "-1"
> public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
> In the default capacity-scheduler.xml file in the resource manager config 
> directory it is 40.
> Can it be unified to avoid confusion when the user creates the file without 
> this configuration. IF he expects the values in the file to be default 
> values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to