[ 
https://issues.apache.org/jira/browse/YARN-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528459#comment-14528459
 ] 

Junping Du commented on YARN-3523:
----------------------------------

Latest patch LGTM. However, I think we don't need @Private for every method 
because we already specified it in class level. In most cases, we need some 
different visibility in method level is to override the class level. 
[~vinodkv], what do you think?

> Cleanup ResourceManagerAdministrationProtocol interface audience
> ----------------------------------------------------------------
>
>                 Key: YARN-3523
>                 URL: https://issues.apache.org/jira/browse/YARN-3523
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>              Labels: newbie
>         Attachments: YARN-3523.20150422-1.patch, YARN-3523.20150504-1.patch, 
> YARN-3523.20150505-1.patch
>
>
> I noticed ResourceManagerAdministrationProtocol has @Private audience for the 
> class and @Public audience for methods. It doesn't make sense to me. We 
> should make class audience and methods audience consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to