[
https://issues.apache.org/jira/browse/YARN-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533031#comment-14533031
]
Naganarasimha G R commented on YARN-3581:
-----------------------------------------
Hi [~wangda]
Found few other problems too
# In help for {{yarn rmadmin}} its displayed as {{-addToClusterNodeLabels
\[label1(exclusive=true),label2(exclusive=false),label3\]}} but its not
captured that : if not specified then default exclusive=true.
# while adding non exclusive label {{./yarn rmadmin -addToClusterNodeLabels
label1(exclusive=false)}} got error as {{bash: syntax error near unexpected
token `('}}. and succeeds when {{./yarn rmadmin -addToClusterNodeLabels
label2\\(exclusive=false\\)}} i.e. when we escape the bracket, hence was
wondering can we support it as {{yarn rmadmin -addToClusterNodeLabels
\[label1|exclusive=true,label2|exclusive=false,label3\]}} or {{yarn rmadmin
-addToClusterNodeLabels \[label1|exclusive,label2|nonexclusive,label3\]}}
# If no options are passed for
{{-addToClusterNodeLabels}},{{-removeFromClusterNodeLabels}},{{-replaceLabelsOnNode}}
then we get error message as {{No cluster node-labels are specified}} instead
it should error msg should be followed with the command usage
# -directlyAccessNodeLabelStore is present in {{yarn rmadmin}} and {{ yarn
cluster}} and both places we need to make deprecated.
If you are ok i can take this issue up and will also fix the ones pointed out
by me.
> Deprecate -directlyAccessNodeLabelStore in RMAdminCLI
> -----------------------------------------------------
>
> Key: YARN-3581
> URL: https://issues.apache.org/jira/browse/YARN-3581
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, client, resourcemanager
> Reporter: Wangda Tan
> Assignee: Wangda Tan
>
> In 2.6.0, we added an option called "-directlyAccessNodeLabelStore" to make
> RM can start with label-configured queue settings. After YARN-2918, we don't
> need this option any more, admin can configure queue setting, start RM and
> configure node label via RMAdminCLI without any error.
> In addition, this option is very restrictive, first it needs to run on the
> same node where RM is running if admin configured to store labels in local
> disk.
> Second, when admin run the option when RM is running, multiple process write
> to a same file can happen, this could make node label store becomes invalid.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
