[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533942#comment-14533942
]
Sangjin Lee commented on YARN-3044:
-----------------------------------
Overall it looks good. I think it's real close. I appreciate your patience on
this JIRA. Some minor and not-so-minor comments follow...
(TimelineMetric.java)
- l.48: I we can drop this comment. It is really a reason for the change, but
for the code itself I don't think it needs the rationale.
(YarnConfiguration.java)
- I continue to be somewhat puzzled by the word "container metrics", as it is
used really to emit container entities and events, not metrics. I am OK with
the name as it is for now, and I understand that there is a precedent, but I
hope at least we can revisit these names at some point and normalize them. Let
me know what you think.
(SystemMetricsPublisher.java)
- l. 104: nit: space after "if"
(TimelineServiceV2Publisher.java)
- This hasn't been discussed as much, but I'm wondering when and how we should
set the child entities. For example, when we create a new app attempt entity,
do we want to add it to the app entity as a child? The purpose is quick
navigation to children. This question might be a little beyond the scope of
this patch, and I'm fine with working on that in a separate JIRA.
- l.232: Some of the info entries are redundant from the app attempt registered
event. Are they needed?
- l.330: Now that this is taken care of by the RM timeline collector manager,
do we need this method any more? I don't think it is being called.
> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>
> Key: YARN-3044
> URL: https://issues.apache.org/jira/browse/YARN-3044
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Naganarasimha G R
> Labels: BB2015-05-TBR
> Attachments: YARN-3044-YARN-2928.004.patch,
> YARN-3044-YARN-2928.005.patch, YARN-3044-YARN-2928.006.patch,
> YARN-3044.20150325-1.patch, YARN-3044.20150406-1.patch,
> YARN-3044.20150416-1.patch
>
>
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
