Naganarasimha G R updated YARN-3362:
    Attachment: YARN-3362.20150510-1.patch

Hi [~wangda]
Updating the patch based on your review comments
While testing came across few    issues
* why all labels are default accessible @ root? currently have removed 
{{label.getIsExclusive() && !((AbstractCSQueue) 
root).accessibleToPartition(label)}} check from CapacitySchedulerPage for root 
queue for each label as its always true
* currently accessibility of labels for non root queues, if not specified is * 
as it inherits from parent queue. Is this right ?
* when new partition is added, then the configured max capacity is shown as 100 
but abs max capacity is shown as 0 dint understand why this is handled in this 
way in UI side CapacitySchedulerQueueInfo(ln 73)
  if (maxCapacity < EPSILON || maxCapacity > 1f)
      maxCapacity = 1f;
my guess is code has been added to show that its in the range of 0 to 1f ? if 
so {{maxCapacity < EPSILON}} then maxCapacity=0 and if {{maxCapacity > 1f}} 
then maxCapacity=1f right ?
Also my doubt is why keep max capacity as zero if label is accessible to a 
queue, if max capacity is not specified then it should be 100 right ?

> Add node label usage in RM CapacityScheduler web UI
> ---------------------------------------------------
>                 Key: YARN-3362
>                 URL: https://issues.apache.org/jira/browse/YARN-3362
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, resourcemanager, webapp
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: 2015.05.06 Folded Queues.png, 2015.05.06 Queue 
> Expanded.png, 2015.05.07_3362_Queue_Hierarchy.png, 
> 2015.05.10_3362_Queue_Hierarchy.png, CSWithLabelsView.png, 
> No-space-between-Active_user_info-and-next-queues.png, Screen Shot 2015-04-29 
> at 11.42.17 AM.png, YARN-3362.20150428-3-modified.patch, 
> YARN-3362.20150428-3.patch, YARN-3362.20150506-1.patch, 
> YARN-3362.20150507-1.patch, YARN-3362.20150510-1.patch, capacity-scheduler.xml
> We don't have node label usage in RM CapacityScheduler web UI now, without 
> this, user will be hard to understand what happened to nodes have labels 
> assign to it.

This message was sent by Atlassian JIRA

Reply via email to