[ https://issues.apache.org/jira/browse/YARN-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537869#comment-14537869 ]
Hudson commented on YARN-3587: ------------------------------ FAILURE: Integrated in Hadoop-trunk-Commit #7790 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7790/]) YARN-3587. Fix the javadoc of DelegationTokenSecretManager in yarn, etc. projects. Contributed by Gabor Liptak. (junping_du: rev 7e543c27fa2881aa65967be384a6203bd5b2304f) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/RMDelegationTokenSecretManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineDelegationTokenSecretManagerService.java * hadoop-yarn-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/JHSDelegationTokenSecretManager.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenSecretManager.java * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/token/delegation/DelegationTokenSecretManager.java > Fix the javadoc of DelegationTokenSecretManager in projects of yarn, etc. > ------------------------------------------------------------------------- > > Key: YARN-3587 > URL: https://issues.apache.org/jira/browse/YARN-3587 > Project: Hadoop YARN > Issue Type: Bug > Components: documentation > Affects Versions: 2.7.0 > Reporter: Akira AJISAKA > Assignee: Gabor Liptak > Priority: Minor > Labels: newbie > Fix For: 2.8.0 > > Attachments: YARN-3587.1.patch, YARN-3587.patch > > > In RMDelegationTokenSecretManager and TimelineDelegationTokenSecretManager, > the javadoc of the constructor is as follows: > {code} > /** > * Create a secret manager > * @param delegationKeyUpdateInterval the number of seconds for rolling new > * secret keys. > * @param delegationTokenMaxLifetime the maximum lifetime of the delegation > * tokens > * @param delegationTokenRenewInterval how often the tokens must be renewed > * @param delegationTokenRemoverScanInterval how often the tokens are > scanned > * for expired tokens > */ > {code} > 1. "the number of seconds" should be "the number of milliseconds". > 2. It's better to add time unit to the description of other parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)