[ https://issues.apache.org/jira/browse/YARN-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538017#comment-14538017 ]
Akira AJISAKA commented on YARN-3587: ------------------------------------- Agree with [~djp]. Late +1 from me. Thanks [~djp], [~jianhe], and [~gliptak] for contribution! > Fix the javadoc of DelegationTokenSecretManager in projects of yarn, etc. > ------------------------------------------------------------------------- > > Key: YARN-3587 > URL: https://issues.apache.org/jira/browse/YARN-3587 > Project: Hadoop YARN > Issue Type: Bug > Components: documentation > Affects Versions: 2.7.0 > Reporter: Akira AJISAKA > Assignee: Gabor Liptak > Priority: Minor > Labels: newbie > Fix For: 2.8.0 > > Attachments: YARN-3587.1.patch, YARN-3587.patch > > > In RMDelegationTokenSecretManager and TimelineDelegationTokenSecretManager, > the javadoc of the constructor is as follows: > {code} > /** > * Create a secret manager > * @param delegationKeyUpdateInterval the number of seconds for rolling new > * secret keys. > * @param delegationTokenMaxLifetime the maximum lifetime of the delegation > * tokens > * @param delegationTokenRenewInterval how often the tokens must be renewed > * @param delegationTokenRemoverScanInterval how often the tokens are > scanned > * for expired tokens > */ > {code} > 1. "the number of seconds" should be "the number of milliseconds". > 2. It's better to add time unit to the description of other parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)