[
https://issues.apache.org/jira/browse/YARN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541212#comment-14541212
]
Hadoop QA commented on YARN-3628:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 42s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 33s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 36s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 37s | There were no new checkstyle
issues. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 23s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests | 0m 25s | Tests passed in
hadoop-yarn-api. |
| {color:green}+1{color} | yarn tests | 6m 1s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 44m 49s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12732440/YARN-3628.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f24452d |
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/7907/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-api test log |
https://builds.apache.org/job/PreCommit-YARN-Build/7907/artifact/patchprocess/testrun_hadoop-yarn-api.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/7907/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/7907/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/7907/console |
This message was automatically generated.
> ContainerMetrics should support always-flush mode.
> --------------------------------------------------
>
> Key: YARN-3628
> URL: https://issues.apache.org/jira/browse/YARN-3628
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: YARN-3628.000.patch
>
>
> ContainerMetrics should support always-flush mode.
> It will be good to set ContainerMetrics as always-flush mode if
> yarn.nodemanager.container-metrics.period-ms is configured as 0.
> Currently both 0 and -1 mean flush on completion.
> Also the current default value for
> yarn.nodemanager.container-metrics.period-ms is -1 and the default value for
> yarn.nodemanager.container-metrics.enable is true. So the empty content is
> shown for the active container metrics until it is finished.
> The default value for yarn.nodemanager.container-metrics.period-ms should not
> be -1.
> flushOnPeriod is always false if flushPeriodMs is -1,
> the content will only be shown when the container is finished.
> {code}
> if (finished || flushOnPeriod) {
> registry.snapshot(collector.addRecord(registry.info()), all);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
