[
https://issues.apache.org/jira/browse/YARN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542036#comment-14542036
]
Karthik Kambatla commented on YARN-3628:
----------------------------------------
bq. So the empty content is shown for the active container metrics until it is
finished.
Where are we showing this? jmx or a specific metrics sink?
I am not convinced we should support a period of 0 ms, let alone by default:
each container will be constantly publishing its usage metrics. Assuming
non-positive period implies flushOnExit seems like the right approach to me.
Also, since this was released as part of 2.7, we should avoid incompatible
changes.
> ContainerMetrics should support always-flush mode.
> --------------------------------------------------
>
> Key: YARN-3628
> URL: https://issues.apache.org/jira/browse/YARN-3628
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: YARN-3628.000.patch
>
>
> ContainerMetrics should support always-flush mode.
> It will be good to set ContainerMetrics as always-flush mode if
> yarn.nodemanager.container-metrics.period-ms is configured as 0.
> Currently both 0 and -1 mean flush on completion.
> Also the current default value for
> yarn.nodemanager.container-metrics.period-ms is -1 and the default value for
> yarn.nodemanager.container-metrics.enable is true. So the empty content is
> shown for the active container metrics until it is finished.
> The default value for yarn.nodemanager.container-metrics.period-ms should not
> be -1.
> flushOnPeriod is always false if flushPeriodMs is -1,
> the content will only be shown when the container is finished.
> {code}
> if (finished || flushOnPeriod) {
> registry.snapshot(collector.addRecord(registry.info()), all);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
