[
https://issues.apache.org/jira/browse/YARN-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sunil G updated YARN-3583:
--------------------------
Attachment: 0002-YARN-3583.patch
Thank you [~leftnoteasy] for sharing the comments. Please find updated patch
addressing the same. Also i inlined the changes.
bq.1. NodeIdToLabelsProto can be removed?
In yarn_service_resourcemanager_service_protos, ReplaceLabelsOnNodeRequestProto
still used NodeIdToLabelsProto.
So I feel we can keep the same.
bq.2. NodeIdToLabelsInfoProto could be added to TestPBImplRecords?
I feel existing test case testGetNodeToLabelsResponsePBImpl which is present in
TestPBImplRecords internally covers the verification for
NodeIdToLabelsInfoProto. Pls suggest if otherwise.
bq.3. In TestClientRMService, could you check if the new
getter-api-with-NodeLabel actually works,
Updated the test case with verification
> Support of NodeLabel object instead of plain String in YarnClient side.
> -----------------------------------------------------------------------
>
> Key: YARN-3583
> URL: https://issues.apache.org/jira/browse/YARN-3583
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
> Affects Versions: 2.6.0
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: 0001-YARN-3583.patch, 0002-YARN-3583.patch
>
>
> Similar to YARN-3521, use NodeLabel objects in YarnClient side apis.
> getLabelsToNodes/getNodeToLabels api's can use NodeLabel object instead of
> using plain label name.
> This will help to bring other label details such as Exclusivity to client
> side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
