Sunil G updated YARN-3583:
    Attachment: 0003-YARN-3583.patch

Thank you [~leftnoteasy] for the comments.
Updated a patch addressing the comments.

bq. I think it's better to add it separately to make sure it will be tested.
In TestClientRMServices we have test case and I added new test case in 
TestYarnClient also for GetNodeLabels which will check the NodeIdToLabelsInfo. 
In TestPBImplsRecords, we only have test case for Request and Response PB 
Objects, and the inner values are validated in same. Here we need to test an 
inner object for a ResponsePBImpl and is covered by above tests. Pls let me 
know if this is fine.

> Support of NodeLabel object instead of plain String in YarnClient side.
> -----------------------------------------------------------------------
>                 Key: YARN-3583
>                 URL: https://issues.apache.org/jira/browse/YARN-3583
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>    Affects Versions: 2.6.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3583.patch, 0002-YARN-3583.patch, 
> 0003-YARN-3583.patch
> Similar to YARN-3521, use NodeLabel objects in YarnClient side apis.
> getLabelsToNodes/getNodeToLabels api's can use NodeLabel object instead of 
> using plain label name.
> This will help to bring other label details such as Exclusivity to client 
> side.

This message was sent by Atlassian JIRA

Reply via email to