[ 
https://issues.apache.org/jira/browse/YARN-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547562#comment-14547562
 ] 

Naganarasimha G R commented on YARN-2729:
-----------------------------------------

Thanks [~vinodkv] for replying,

bq. I think once we start marking this script-based provider feature as public, 
the expected output from the script will automatically become a public 
interface unless we explicitly say no. We should start thinking about this now 
to avoid uncertainty in the future?
True, its better to think about it for both script(YARN-2729) and config 
(YARN-2923) based providers now itself if we are making it as public. Initial 
thought what i have is 
{code}
NODE_LABELS=<Label Name>|<Label Type>[,Labels]
where Label Type = Partition, Constraint....
and default if not specified can be Partition.
{code}
Going further i think distributed labels will be more suitable for 
constraints/attribute [YARN-3409] so we can think of having {{Constraint}} as 
default too. Also we need not specify Whether Partition is Exclusive or 
Non-Exclusive, it does not make significance from the NM as Exclusivity of 
partition labels are already specified while adding it to cluster labels set in 
RM.
One More suggestion is In Node Label object, can we think of having Enum 
instead of isExclusive, Enum can have ExclusivePartion,NonExclusivePartition, 
(Constraint in future) and so on.
bq. Isn't AbstractNodeLabelsProvider a good place to do these steps?
Well AbstractNodeLabelsProvider will only be applicable to the whitelisted 
providers (Config and script) currently, And also the purpose was for removing 
duplicate code related to Timertask and related configs. So is your suggestion 
to expose the AbstractNodeLabelsProvider to be a public interface ? or can we 
think of having intermediate manager class and have configurations for timer 
requirement and leave the NodeLabelsProvider interface as is. ?


> Support script based NodeLabelsProvider Interface in Distributed Node Label 
> Configuration Setup
> -----------------------------------------------------------------------------------------------
>
>                 Key: YARN-2729
>                 URL: https://issues.apache.org/jira/browse/YARN-2729
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2729.20141023-1.patch, YARN-2729.20141024-1.patch, 
> YARN-2729.20141031-1.patch, YARN-2729.20141120-1.patch, 
> YARN-2729.20141210-1.patch, YARN-2729.20150309-1.patch, 
> YARN-2729.20150322-1.patch, YARN-2729.20150401-1.patch, 
> YARN-2729.20150402-1.patch, YARN-2729.20150404-1.patch, 
> YARN-2729.20150517-1.patch
>
>
> Support script based NodeLabelsProvider Interface in Distributed Node Label 
> Configuration Setup . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to