[
https://issues.apache.org/jira/browse/YARN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548485#comment-14548485
]
Wangda Tan commented on YARN-3565:
----------------------------------
[~Naganarasimha], thanks for updating, mostly looks good, two minor comments:
Changes in NodeStatusUpdaterImpl:
- convertToNodeLabelSet could be removed
- {{+ (nodeLabels));}} this line change is not necessary?
> NodeHeartbeatRequest/RegisterNodeManagerRequest should use NodeLabel object
> instead of String
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-3565
> URL: https://issues.apache.org/jira/browse/YARN-3565
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, client, resourcemanager
> Reporter: Wangda Tan
> Assignee: Naganarasimha G R
> Priority: Blocker
> Attachments: YARN-3565-20150502-1.patch, YARN-3565.20150515-1.patch,
> YARN-3565.20150516-1.patch
>
>
> Now NM HB/Register uses Set<String>, it will be hard to add new fields if we
> want to support specifying NodeLabel type such as exclusivity/constraints,
> etc. We need to make sure rolling upgrade works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
