[ 
https://issues.apache.org/jira/browse/YARN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547316#comment-14547316
 ] 

Allen Wittenauer commented on YARN-3565:
----------------------------------------

bq. I think currently white space is getting calculated on the diff output 
rather just the modified lines only (diff has some lines before and after the 
modifications).

That's not how it works.  But I'll look to see if there is an off-by-one error 
here.

> NodeHeartbeatRequest/RegisterNodeManagerRequest should use NodeLabel object 
> instead of String
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-3565
>                 URL: https://issues.apache.org/jira/browse/YARN-3565
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>            Priority: Blocker
>         Attachments: YARN-3565-20150502-1.patch, YARN-3565.20150515-1.patch, 
> YARN-3565.20150516-1.patch
>
>
> Now NM HB/Register uses Set<String>, it will be hard to add new fields if we 
> want to support specifying NodeLabel type such as exclusivity/constraints, 
> etc. We need to make sure rolling upgrade works.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to