[
https://issues.apache.org/jira/browse/YARN-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551358#comment-14551358
]
Hadoop QA commented on YARN-3684:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 47s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 10 new or modified test files. |
| {color:green}+1{color} | javac | 7m 38s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 39s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 40s | The applied patch generated
35 new checkstyle issues (total was 495, now 445). |
| {color:green}+1{color} | whitespace | 0m 48s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 1m 6s | The patch appears to introduce 4
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 6m 29s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 43m 44s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-yarn-server-nodemanager |
| | Dead store to user in
org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.deleteAsUser(DeletionAsUserContext)
At
DefaultContainerExecutor.java:org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.deleteAsUser(DeletionAsUserContext)
At DefaultContainerExecutor.java:[line 476] |
| | Dead store to appId in
org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.launchContainer(ContainerStartContext)
At
DefaultContainerExecutor.java:org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.launchContainer(ContainerStartContext)
At DefaultContainerExecutor.java:[line 147] |
| | Dead store to user in
org.apache.hadoop.yarn.server.nodemanager.DockerContainerExecutor.deleteAsUser(DeletionAsUserContext)
At
DockerContainerExecutor.java:org.apache.hadoop.yarn.server.nodemanager.DockerContainerExecutor.deleteAsUser(DeletionAsUserContext)
At DockerContainerExecutor.java:[line 458] |
| |
org.apache.hadoop.yarn.server.nodemanager.executor.DeletionAsUserContext.getBasedirs()
may expose internal representation by returning DeletionAsUserContext.basedirs
At DeletionAsUserContext.java:by returning DeletionAsUserContext.basedirs At
DeletionAsUserContext.java:[line 81] |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12733961/YARN-3648.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7438966 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/8010/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-YARN-Build/8010/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8010/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8010/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8010/console |
This message was automatically generated.
> Change ContainerExecutor's primary lifecycle methods to use a more extensible
> mechanism for passing information.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-3684
> URL: https://issues.apache.org/jira/browse/YARN-3684
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-3648.001.patch
>
>
> As per description in parent JIRA : Adding additional arguments to key
> ContainerExecutor methods ( e.g startLocalizer or launchContainer ) would
> break the existing ContainerExecutor interface and would require changes to
> all executor implementations in YARN. In order to make this interface less
> brittle in the future, it would make sense to encapsulate arguments in some
> kind of a ‘context’ object which could be modified/extended without breaking
> the ContainerExecutor interface in the future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
