Vinod Kumar Vavilapalli commented on YARN-3684:

This is a good first step, and a straightforward refactor.

The latest patch looks good, +1. Checking this in.

> Change ContainerExecutor's primary lifecycle methods to use a more extensible 
> mechanism for passing information. 
> -----------------------------------------------------------------------------------------------------------------
>                 Key: YARN-3684
>                 URL: https://issues.apache.org/jira/browse/YARN-3684
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Sidharta Seethana
>            Assignee: Sidharta Seethana
>         Attachments: YARN-3648.001.patch, YARN-3684.002.patch
> As per description in parent JIRA :  Adding additional arguments to key 
> ContainerExecutor methods ( e.g startLocalizer or launchContainer ) would 
> break the existing ContainerExecutor interface and would require changes to 
> all executor implementations in YARN. In order to make this interface less 
> brittle in the future, it would make sense to encapsulate arguments in some 
> kind of a ‘context’ object which could be modified/extended without breaking 
> the ContainerExecutor interface in the future.

This message was sent by Atlassian JIRA

Reply via email to