[
https://issues.apache.org/jira/browse/YARN-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553646#comment-14553646
]
Karthik Kambatla commented on YARN-1012:
----------------------------------------
Looks like the patch is missing ResourceUtilizationPBImpl, and hence doesn't
build. Could you please include those new files as well?
Comments on the patch itself:
# Given this is all new code, let us hold off on exposing it to end users just
yet. Can we mark ContainerStatus#getUtilization Public-Unstable?
# Is there a reason folks would want to turn off tracking utilization? If not,
let us get rid of the config and always track it?
# When logging at debug level, we want to check if debug logging is enabled to
avoid string creation and concat.
# I notice that we are using a float for virtual_cores. Do we anticipate using
this value in any calculations? If yes, should we change this to be millivcores
and int instead to avoid those floating point operations. Given this is just
tracking utilization, I suspect we ll do any calculations.
# In ContainerMonitorsImpl, we save utilization and then set container metrics.
Should we leave this as is? Or, link them up so that the ContainerMonitorsImpl
is aware of only one of them?
> NM should report resource utilization of running containers to RM in heartbeat
> ------------------------------------------------------------------------------
>
> Key: YARN-1012
> URL: https://issues.apache.org/jira/browse/YARN-1012
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.7.0
> Reporter: Arun C Murthy
> Assignee: Inigo Goiri
> Attachments: YARN-1012-1.patch, YARN-1012-2.patch, YARN-1012-3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
