Devaraj K commented on YARN-41:

Thanks a lot [~djp] for review and for the comments.

bq. So, the node after shutdown will become DECOMMISSIONED as final state? I 
think we don't expect these nodes show in DECOMMISSIONED list. Isn't it? May be 
we should have some new NodeState as SHUTDOWN for this case.

{code:xml}Shouldn't be counting shut-down nodes in LOST. Adding a new state is 
perhaps an over-kill, DECOMMISSIONED is the closest I can think of.{code}

Initial got the above comment from Vinod about the node state. I feel we can 
proceed here with DECOMMISSIONED state as Vinod suggested and also it will not 
create any compatibility issue. Adding a new state and Ui change can be done as 
per your suggestions with the following up jira and can be implemented for 
trunk without causing the compatibility issue in 2.x versions. Please post your 
comments on this.

bq. If other exception get thrown here with wrong message, the test would still 
pass. Isn't it? better to catch all exceptions and check if it is YarnException.
I don't see any problem with this test. If any other exception gets here then 
that exception would be directly thrown from the test and anyway test fails 
with that exception. Please correct me if I am missing anything here.

> The RM should handle the graceful shutdown of the NM.
> -----------------------------------------------------
>                 Key: YARN-41
>                 URL: https://issues.apache.org/jira/browse/YARN-41
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: nodemanager, resourcemanager
>            Reporter: Ravi Teja Ch N V
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-3494.1.patch, MAPREDUCE-3494.2.patch, 
> MAPREDUCE-3494.patch, YARN-41-1.patch, YARN-41-2.patch, YARN-41-3.patch, 
> YARN-41-4.patch, YARN-41-5.patch, YARN-41-6.patch, YARN-41.patch
> Instead of waiting for the NM expiry, RM should remove and handle the NM, 
> which is shutdown gracefully.

This message was sent by Atlassian JIRA

Reply via email to