Joep Rottinghuis updated YARN-3706:
    Attachment: YARN-3726-YARN-2928.003.patch

Moved common classes into common package to separate them from the actual 
talbes and column definitions.
Cleaned up some of the methods. Pushed common code into column class.

Left to do:
- Fix remainder of unit test that is currently commented out
- Create similar readResult for the column prefix.
- Creating ColumnFactory to move EntityColumn valueOf methods into.
- Clean up unneeded methods from TimelineWriterUtils
- Add additional unit tests for methods newly added to TimelineWriterUtils
- Create a reader method (some class) that reads an entire entity back
- Add unit test to read entire entity back and then compare all values to 
written entity. That's pretty much the ultimate test and will ensure we have 
clean reader APIs.

> Generalize native HBase writer for additional tables
> ----------------------------------------------------
>                 Key: YARN-3706
>                 URL: https://issues.apache.org/jira/browse/YARN-3706
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Joep Rottinghuis
>            Assignee: Joep Rottinghuis
>            Priority: Minor
>         Attachments: YARN-3706-YARN-2928.001.patch, 
> YARN-3726-YARN-2928.002.patch, YARN-3726-YARN-2928.003.patch
> When reviewing YARN-3411 we noticed that we could change the class hierarchy 
> a little in order to accommodate additional tables easily.
> In order to get ready for benchmark testing we left the original layout in 
> place, as performance would not be impacted by the code hierarchy.
> Here is a separate jira to address the hierarchy.

This message was sent by Atlassian JIRA

Reply via email to