Karthik Kambatla commented on YARN-2716:

Thanks for the thorough review, Jian. Sorry for missing some simple things in 
the patch. 

bq. will the safeDelete throw noNodeExist exception if deleting a non-existing 
safeDelete checks if the znode exists before attempting to delete it. So, 
shouldn't throw NoNodeException.

bq. why in HA case, zkRetryInterval is calculated as below
When HA is not enabled, we should give the store as much time as possible to 
connect to ZK. When HA is enabled, it is possible the other RM has better 
chance of connecting to ZK; so, we should give up trying by session-timeout. 
YARN-2054 has all the details.

Posting a patch shortly to address all the review feedback.

> Refactor ZKRMStateStore retry code with Apache Curator
> ------------------------------------------------------
>                 Key: YARN-2716
>                 URL: https://issues.apache.org/jira/browse/YARN-2716
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Jian He
>            Assignee: Karthik Kambatla
>         Attachments: yarn-2716-1.patch, yarn-2716-prelim.patch, 
> yarn-2716-prelim.patch, yarn-2716-super-prelim.patch
> Per suggestion by [~kasha] in YARN-2131,  it's nice to use curator to 
> simplify the retry logic in ZKRMStateStore.

This message was sent by Atlassian JIRA

Reply via email to