[ 
https://issues.apache.org/jira/browse/YARN-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575395#comment-14575395
 ] 

Jian He commented on YARN-2716:
-------------------------------

bq. safeDelete checks if the znode exists before attempting to delete it. So, 
shouldn't throw NoNodeException.
ah, right sorry, I overlooked the implementation of the method

only comment is :
- removeApplicationStateInternal can also use the 
{{curatorFramework.delete().deletingChildrenIfNeeded()}} instead of adding all 
children manually ?

> Refactor ZKRMStateStore retry code with Apache Curator
> ------------------------------------------------------
>
>                 Key: YARN-2716
>                 URL: https://issues.apache.org/jira/browse/YARN-2716
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Jian He
>            Assignee: Karthik Kambatla
>         Attachments: yarn-2716-1.patch, yarn-2716-2.patch, 
> yarn-2716-prelim.patch, yarn-2716-prelim.patch, yarn-2716-super-prelim.patch
>
>
> Per suggestion by [~kasha] in YARN-2131,  it's nice to use curator to 
> simplify the retry logic in ZKRMStateStore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to