Naganarasimha G R commented on YARN-3045:

Hi [~djp],[~sjlee0] & [~zjshen],
Please find the attached patch with rebasing on top of 3792.
I would like to discuss regarding 2 points 
# I prefer to have all the container related events and entities to be 
published by NMTimelinePublisher, so wanted push container usage metrics also 
to NMTimelinePublisher. This will ensure all NM timeline stuff are put in one 
place and remove thread pool handling in {{ContainerMonitorImpl}} (Though later 
point will not be a issue when YARN-3367 is handled but due to the former 
reason i would prefer to move)
# While testing in TestDistributedShell found out that few of the container 
metrics events were failing as there will be race condition. When the AM 
container finishes and removes the collector for the app, still there is 
possibility that all the events published for the app by the current NM and 
other NM are still in pipeline, so was wondering whether we can have timer task 
which periodically cleans up collector after some period and not imm remove it 
when AM container is finished.

> [Event producers] Implement NM writing container lifecycle events to ATS
> ------------------------------------------------------------------------
>                 Key: YARN-3045
>                 URL: https://issues.apache.org/jira/browse/YARN-3045
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>              Labels: BB2015-05-TBR
>         Attachments: YARN-3045-YARN-2928.002.patch, 
> YARN-3045-YARN-2928.003.patch, YARN-3045-YARN-2928.004.patch, 
> YARN-3045.20150420-1.patch
> Per design in YARN-2928, implement NM writing container lifecycle events and 
> container system metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to