[ 
https://issues.apache.org/jira/browse/YARN-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595147#comment-14595147
 ] 

Hadoop QA commented on YARN-3837:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m 34s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 33s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 33s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 29s | There were no new checkstyle 
issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 1  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   0m 55s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   3m 10s | Tests passed in 
hadoop-yarn-server-applicationhistoryservice. |
| | |  39m 49s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12740923/0002-YARN-3837.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c7d022b |
| whitespace | 
https://builds.apache.org/job/PreCommit-YARN-Build/8303/artifact/patchprocess/whitespace.txt
 |
| hadoop-yarn-server-applicationhistoryservice test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8303/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8303/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8303/console |


This message was automatically generated.

> javadocs of TimelineAuthenticationFilterInitializer give wrong prefix for 
> auth options
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-3837
>                 URL: https://issues.apache.org/jira/browse/YARN-3837
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: 0001-YARN-3837.patch, 0002-YARN-3837.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The javadocs for {{TimelineAuthenticationFilterInitializer}} talk about the 
> prefix {{yarn.timeline-service.authentication.}}, but the code uses {{ 
> "yarn.timeline-service.http-authentication."}}  as the prefix.
> best to use {{@value}} and let the javadocs sort it out for themselves.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to