Devaraj K commented on YARN-3837:

[~bibinchundatt], I agree that it is not related to the patch, however you can 
fix the trailing white space at line number 66 after applying the patch to 
avoid the Jenkins white space warning.

Otherwise patch looks good to me.

> javadocs of TimelineAuthenticationFilterInitializer give wrong prefix for 
> auth options
> --------------------------------------------------------------------------------------
>                 Key: YARN-3837
>                 URL: https://issues.apache.org/jira/browse/YARN-3837
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: 0001-YARN-3837.patch, 0002-YARN-3837.patch
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
> The javadocs for {{TimelineAuthenticationFilterInitializer}} talk about the 
> prefix {{yarn.timeline-service.authentication.}}, but the code uses {{ 
> "yarn.timeline-service.http-authentication."}}  as the prefix.
> best to use {{@value}} and let the javadocs sort it out for themselves.

This message was sent by Atlassian JIRA

Reply via email to