[
https://issues.apache.org/jira/browse/YARN-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596437#comment-14596437
]
Giovanni Matteo Fumarola commented on YARN-3116:
------------------------------------------------
Thanks [~zjshen] for quickly reviewing the patch & your comments.
1. I agree that ContainerTokenIdentifier would be a better place to do it so
that we keep the flag internal but the ContainerTokenIdentifier is created
before the state transition in RMAppAttempt that sets the AM flag in
RMContainer. I can try to recreate ContainerTokenIdentifier at the AM launch
but that looks unwieldy. Do you have any suggestions on how to do it cleaner?
2. Again a good observation, I'll add this in the next iteration of the
patch based on your suggestion for (1) above.
> [Collector wireup] We need an assured way to determine if a container is an
> AM container on NM
> ----------------------------------------------------------------------------------------------
>
> Key: YARN-3116
> URL: https://issues.apache.org/jira/browse/YARN-3116
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, timelineserver
> Reporter: Zhijie Shen
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-3116.patch
>
>
> In YARN-3030, to start the per-app aggregator only for a started AM
> container, we need to determine if the container is an AM container or not
> from the context in NM (we can do it on RM). This information is missing,
> such that we worked around to considered the container with ID "xxxx_01" as
> the AM container. Unfortunately, this is neither necessary or sufficient
> condition. We need to have a way to determine if a container is an AM
> container on NM. We can add flag to the container object or create an API to
> do the judgement. Perhaps the distributed AM information may also be useful
> to YARN-2877.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
