[
https://issues.apache.org/jira/browse/YARN-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609280#comment-14609280
]
Giovanni Matteo Fumarola commented on YARN-3116:
------------------------------------------------
Thanks [~zjshen] for the comments & for the bug identified in LeafQueue.
1. I modified the Classes ContainerXXXX according your suggestion.
2. I added a new test to check the value of the new flag and I edit an existing
test to check its value.
3. I edited LeafQueue to avoid the existing bug.
I ran test-patch.sh in my local box and I got some checkstyle issues.
LeafQueue.java:1: File length is 2,088 lines (max allowed is 2,000) - I added
only 1 line.
LeafQueue.java:742:3: Method length is 233 lines (max allowed is 150) - I added
only 1 line.
LeafQueue.java:833:73: Expression can be simplified - It is only 2 simple
Boolean conditions.
SchedulerApplicationAttempt.java:480:65: Expression can be simplified - It is
only 2 simple Boolean conditions.
RMContainerTokenSecretManager.java:206: First sentence should end with a period
- I did not figure out this. The some comment is in a different methods.
RMContainerTokenSecretManager.java:220:16: More than 7 parameters (found 9) - I
added only 1 parameter.
ContainerTokenIdentifier.java:81:10: More than 7 parameters (found 12) - I
added only 1 parameter.
> [Collector wireup] We need an assured way to determine if a container is an
> AM container on NM
> ----------------------------------------------------------------------------------------------
>
> Key: YARN-3116
> URL: https://issues.apache.org/jira/browse/YARN-3116
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, timelineserver
> Reporter: Zhijie Shen
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-3116.patch, YARN-3116.v2.patch, YARN-3116.v3.patch
>
>
> In YARN-3030, to start the per-app aggregator only for a started AM
> container, we need to determine if the container is an AM container or not
> from the context in NM (we can do it on RM). This information is missing,
> such that we worked around to considered the container with ID "xxxx_01" as
> the AM container. Unfortunately, this is neither necessary or sufficient
> condition. We need to have a way to determine if a container is an AM
> container on NM. We can add flag to the container object or create an API to
> do the judgement. Perhaps the distributed AM information may also be useful
> to YARN-2877.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
