[ 
https://issues.apache.org/jira/browse/YARN-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naganarasimha G R updated YARN-3045:
------------------------------------
    Attachment: YARN-3045-YARN-2928.005.patch

Hi [~djp], [~sjlee0] & [~zjshen],
Attaching a patch with moving container metrics publishing to 
{{NMTimelinePublisher}}. and also have reworked on [~sjlee0]'s comments except 
for :
# ??java.lang.NullPointerException is thrown @ 
TimelineServiceV2Publisher.putEntity(TimelineServiceV2Publisher.java:276)?? 
because appCreated is pushed to SystemMetricsPublisher in RMAPPImpl(l 456) 
constructor but the {{application.startTimelineCollector}} is called after 
RMAPPImpl constructor, so if the machine is fast then it can throw 
NullPointerException, I am working on YARN-3127 which will modify this flow so 
thinking of handling there, thoughts ?
# ??l.223: minor nit, but let's make inner classes static unless they need to 
be non-static?? Instead of NMTimelinePublisher extending EventHandler 
interface, private inner class is created so that the interface methods are not 
exposed as public methods of Publisher, Hope this should be ok as this is the 
same design followed in RM's SMP, thoughts ?


> [Event producers] Implement NM writing container lifecycle events to ATS
> ------------------------------------------------------------------------
>
>                 Key: YARN-3045
>                 URL: https://issues.apache.org/jira/browse/YARN-3045
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3045-YARN-2928.002.patch, 
> YARN-3045-YARN-2928.003.patch, YARN-3045-YARN-2928.004.patch, 
> YARN-3045-YARN-2928.005.patch, YARN-3045.20150420-1.patch
>
>
> Per design in YARN-2928, implement NM writing container lifecycle events and 
> container system metrics to ATS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to