Jian He commented on YARN-2003:

thanks for the updating ! some more comments:

bq. Yes. We are planning to check for acl's (priority acls) in this method
A bunch of other similar ACL checks are done asynchronously (see 
LeafQueue#submitApplication), though I think failing submit call synchronously 
is better. We should also, at some point, move all the checks in one place, 
rather than spreading across multiple places. 
- AbstractYarnScheduler#updateApplicationPriority can be removed. It can be 
added whenever it’s needed. 
- SchedulableEntity#getApplicationPriority -> SchedulableEntity#getPriority?
- authenticateApplicationPriority -> checkAppPriority ?
- RMAppManager#createAndPopulateNewRMApp : if user doesn’t have access to the 
default app priority acl, it’ll be ignored.

- The existing priority is using the semantics that lower integer means higher 
priority. Is it more intuitive to use higher integer to indicate higher 
priority? Otherwise,  below code is quite confusing to me - if priority is less 
than maxPriority, throw exception;
if (priority.compareTo(getMaxClusterLevelAppPriority()) < 0) {
throw new YarnException("Invalid priority as Queue: " + queueName
      + " 
cannot support more than priority '"
      + getMaxClusterLevelAppPriority() + 

 - Change in AppAddedSchedulerEvent - how about changing the construction to 
just passing the submissionContext reference ? 
- Add a test that LeafQueue#pendingApplications is honoring app Priority too ?

> Support for Application priority : Changes in RM and Capacity Scheduler
> -----------------------------------------------------------------------
>                 Key: YARN-2003
>                 URL: https://issues.apache.org/jira/browse/YARN-2003
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>              Labels: BB2015-05-TBR
>         Attachments: 0001-YARN-2003.patch, 00010-YARN-2003.patch, 
> 0002-YARN-2003.patch, 0003-YARN-2003.patch, 0004-YARN-2003.patch, 
> 0005-YARN-2003.patch, 0006-YARN-2003.patch, 0007-YARN-2003.patch, 
> 0008-YARN-2003.patch, 0009-YARN-2003.patch, 0011-YARN-2003.patch, 
> 0012-YARN-2003.patch, 0013-YARN-2003.patch, 0014-YARN-2003.patch, 
> 0015-YARN-2003.patch, 0016-YARN-2003.patch, 0017-YARN-2003.patch
> AppAttemptAddedSchedulerEvent should be able to receive the Job Priority from 
> Submission Context and store.
> Later this can be used by Scheduler.

This message was sent by Atlassian JIRA

Reply via email to