[ https://issues.apache.org/jira/browse/YARN-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627340#comment-14627340 ]
Hadoop QA commented on YARN-3925: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 15m 14s | Findbugs (version ) appears to be broken on trunk. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 2 new or modified test files. | | {color:green}+1{color} | javac | 7m 44s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 0m 37s | The applied patch generated 23 new checkstyle issues (total was 0, now 23). | | {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 22s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 13s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 6m 17s | Tests passed in hadoop-yarn-server-nodemanager. | | | | 43m 2s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12745349/YARN-3925.000.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 0a16ee6 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/8537/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt | | hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8537/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8537/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8537/console | This message was automatically generated. > ContainerLogsUtils#getContainerLogFile fails to read container log files from > full disks. > ----------------------------------------------------------------------------------------- > > Key: YARN-3925 > URL: https://issues.apache.org/jira/browse/YARN-3925 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.7.1 > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Critical > Attachments: YARN-3925.000.patch > > > ContainerLogsUtils#getContainerLogFile fails to read files from full disks. > {{getContainerLogFile}} depends on > {{LocalDirsHandlerService#getLogPathToRead}} to get the log file, but > {{LocalDirsHandlerService#getLogPathToRead}} calls > {{logDirsAllocator.getLocalPathToRead}} and {{logDirsAllocator}} uses > configuration {{YarnConfiguration.NM_LOG_DIRS}}, which will be updated to not > include full disks in {{LocalDirsHandlerService#checkDirs}}: > {code} > Configuration conf = getConfig(); > List<String> localDirs = getLocalDirs(); > conf.setStrings(YarnConfiguration.NM_LOCAL_DIRS, > localDirs.toArray(new String[localDirs.size()])); > List<String> logDirs = getLogDirs(); > conf.setStrings(YarnConfiguration.NM_LOG_DIRS, > logDirs.toArray(new String[logDirs.size()])); > {code} > ContainerLogsUtils#getContainerLogFile is used by NMWebServices#getLogs and > ContainerLogsPage.ContainersLogsBlock#render to read the log. -- This message was sent by Atlassian JIRA (v6.3.4#6332)