[ https://issues.apache.org/jira/browse/YARN-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641608#comment-14641608 ]
Hudson commented on YARN-3925: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk #2194 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2194/]) YARN-3925. ContainerLogsUtils#getContainerLogFile fails to read container log files from full disks. Contributed by zhihai xu (jlowe: rev ff9c13e0a739bb13115167dc661b6a16b2ed2c04) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestContainerLogsPage.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LocalDirsHandlerService.java * hadoop-yarn-project/CHANGES.txt > ContainerLogsUtils#getContainerLogFile fails to read container log files from > full disks. > ----------------------------------------------------------------------------------------- > > Key: YARN-3925 > URL: https://issues.apache.org/jira/browse/YARN-3925 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.7.1 > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Critical > Fix For: 2.7.2 > > Attachments: YARN-3925.000.patch, YARN-3925.001.patch > > > ContainerLogsUtils#getContainerLogFile fails to read files from full disks. > {{getContainerLogFile}} depends on > {{LocalDirsHandlerService#getLogPathToRead}} to get the log file, but > {{LocalDirsHandlerService#getLogPathToRead}} calls > {{logDirsAllocator.getLocalPathToRead}} and {{logDirsAllocator}} uses > configuration {{YarnConfiguration.NM_LOG_DIRS}}, which will be updated to not > include full disks in {{LocalDirsHandlerService#checkDirs}}: > {code} > Configuration conf = getConfig(); > List<String> localDirs = getLocalDirs(); > conf.setStrings(YarnConfiguration.NM_LOCAL_DIRS, > localDirs.toArray(new String[localDirs.size()])); > List<String> logDirs = getLogDirs(); > conf.setStrings(YarnConfiguration.NM_LOG_DIRS, > logDirs.toArray(new String[logDirs.size()])); > {code} > ContainerLogsUtils#getContainerLogFile is used by NMWebServices#getLogs and > ContainerLogsPage.ContainersLogsBlock#render to read the log. -- This message was sent by Atlassian JIRA (v6.3.4#6332)