[
https://issues.apache.org/jira/browse/YARN-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MENG DING updated YARN-1645:
----------------------------
Attachment: YARN-1645-YARN-1197.5.patch
I think you are right that these functions don't need to be synchronized.
Originally I was directly modifying container sizes in
{{changeContainerResourceInternal}}, so I thought I need to synchronize
functions that may potentially access the same containers. This is no longer
the case as container size are now changed in ContainerImpl via events, and
access to a container is already properly synchronized in ContainerImpl.
Thanks for catching this. Attach updated patch.
> ContainerManager implementation to support container resizing
> -------------------------------------------------------------
>
> Key: YARN-1645
> URL: https://issues.apache.org/jira/browse/YARN-1645
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Wangda Tan
> Assignee: MENG DING
> Attachments: YARN-1645-YARN-1197.3.patch,
> YARN-1645-YARN-1197.4.patch, YARN-1645-YARN-1197.5.patch, YARN-1645.1.patch,
> YARN-1645.2.patch, yarn-1645.1.patch
>
>
> Implementation of ContainerManager for container resize, including:
> 1) ContainerManager resize logic
> 2) Relevant test cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
