Varun Saxena commented on YARN-3814:

[~zjshen], [~sjlee0] had a look at YARN-3049.
The REST API part is quite similar except minor differences. Those being :
# Cluster ID is mandatory in YARN-3049 whereas in this patch its optional. Will 
be taken from config if not supplied.
# If flowId or any other long value in query is not a numeric value, YARN-3049 
will send Internal Server Error. This patch will reply with Bad Request error.
# User ID is taken from request if not supplied in YARN-3049. Here, we do not 
handle this case.
# relatesTo and isRelatedTo is given in query in YARN-3049 in format
[type1]:[id1]:[id2]:[id3], [type2]:[id4]:[id5]
In this patch, format is as under :
[type1]:[id1];[id2];[id3], [type2]:[id4];[id5]

So we can decide on these points of difference and consolidate this code.
I have added 19 test cases in this patch as well.
Maybe REST API code can be consolidate in this JIRA with HBase implementation 
in YARN-3049.
Thoughts ?

> REST API implementation for getting raw entities in TimelineReader
> ------------------------------------------------------------------
>                 Key: YARN-3814
>                 URL: https://issues.apache.org/jira/browse/YARN-3814
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-3814-YARN-2928.01.patch

This message was sent by Atlassian JIRA

Reply via email to