[ https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634128#comment-14634128 ]
Sangjin Lee commented on YARN-3814: ----------------------------------- bq. 1. Cluster ID is mandatory in YARN-3049 whereas in this patch its optional. Will be taken from config if not supplied. Agreed. The default use case of the reader is it serves data that belongs to its own cluster. If the cluster is not specified in the query, it should simply assume the "current" cluster. In terms of the general query pattern, I'd just like to make sure we follow the correct URL query syntax. For example, characters such as ":" are reserved characters in URL that are not directly allowed in queries or other parts of the URL. They should always be properly encoded (e.g. "%3A"). Just to be sure. > REST API implementation for getting raw entities in TimelineReader > ------------------------------------------------------------------ > > Key: YARN-3814 > URL: https://issues.apache.org/jira/browse/YARN-3814 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Varun Saxena > Assignee: Varun Saxena > Attachments: YARN-3814-YARN-2928.01.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)