[ https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642182#comment-14642182 ]
Akira AJISAKA commented on YARN-3958: ------------------------------------- Thanks [~varun_saxena] for the comment. bq. Pls note hadoop-yarn-api does not have dependency on hadoop-yarn-common in its pom.xml Change can be made but this should go in branch-2 then ? I understand. We cannot move YarnConfiguration class in branch-2. bq. Moreover, realistically will somebody add a YARN related config in yarn-default.xml but not add it in YarnConfiguration class ? I think unlikely. The reverse happens far more frequently. Make sense to me. bq. So in branch-2 we can just move this test to hadoop-yarn-api and in trunk, move YarnConfiguration to hadoop-yarn-common. I'll commit your latest patch in trunk and branch-2. Now I'm thinking moving YarnConfiguration to yarn-common in trunk makes little sense because it is unlikely that someone adds a config in yarn-default.xml but not add it in YarnConfiguration.java, as you said. > TestYarnConfigurationFields should be moved to hadoop-yarn-api > -------------------------------------------------------------- > > Key: YARN-3958 > URL: https://issues.apache.org/jira/browse/YARN-3958 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.7.0 > Reporter: Varun Saxena > Assignee: Varun Saxena > Attachments: YARN-3958.01.patch, YARN-3958.02.patch, > YARN-3958.03.patch > > > Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The > test is for checking whether all the configurations declared in > YarnConfiguration exist in yarn-default.xml or not. > But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this > file, it is not necessary that this test will be run. So if the developer > misses to update yarn-default.xml and patch is committed, it will lead to > unnecessary test failures after commit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)