[
https://issues.apache.org/jira/browse/YARN-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643215#comment-14643215
]
Wangda Tan commented on YARN-3873:
----------------------------------
[~sunilg], thanks for working on this, looked at main logic of the patch,
haven't looked at tests yet. Two major comments:
1) It's no need to deprecate getApplicationComparator, it's not a public API,
we should simply remove it.
2) Can we assume pendingApplication's ordering policy is equals to
activeApplication's ordering policy? I think we can assume this at least for
now. For example, fair/priority/fifo. This assumption can avoid configure for
"pending-application-ordering-policy". And we don't need to create a
"getActiveIterator" in OrderingPolicy, we can reuse "getAssignmentIterator".
Thoughts?
> pendingApplications in LeafQueue should also use OrderingPolicy
> ---------------------------------------------------------------
>
> Key: YARN-3873
> URL: https://issues.apache.org/jira/browse/YARN-3873
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Affects Versions: 2.7.0
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: 0001-YARN-3873.patch, 0002-YARN-3873.patch,
> 0003-YARN-3873.patch, 0004-YARN-3873.patch
>
>
> Currently *pendingApplications* in LeafQueue is using
> {{applicationComparator}} from CapacityScheduler. This can be changed and
> pendingApplications can use the OrderingPolicy configured in Queue level
> (Fifo/Fair as configured).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
