[jira] [Commented] (YARN-3873) pendingApplications in LeafQueue should also use OrderingPolicy

[Wangda Tan (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680517#comment-14680517
 ] 

Wangda Tan commented on YARN-3873:
----------------------------------

[~sunilg],
Sorry I misread your patch. I think the patch generally LGTM.

Two minor comments:
- Could you add a test to verify pendingApplication will be ordered according 
to customized ordering policy? (Currently it is FIFO only in your patch, 
correct?)
- Following two initialization is not necessary and confusing, I think they 
should be removed:

{code}
  private OrderingPolicy<FiCaSchedulerApp> pendingOrderingPolicy =
      new FifoOrderingPolicy<FiCaSchedulerApp>();
{code}

{code}
  private OrderingPolicy<FiCaSchedulerApp> 
    orderingPolicy = new FifoOrderingPolicy<FiCaSchedulerApp>();
{code}

Thanks,

> pendingApplications in LeafQueue should also use OrderingPolicy
> ---------------------------------------------------------------
>
>                 Key: YARN-3873
>                 URL: https://issues.apache.org/jira/browse/YARN-3873
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>    Affects Versions: 2.7.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3873.patch, 0002-YARN-3873.patch, 
> 0003-YARN-3873.patch, 0004-YARN-3873.patch, 0005-YARN-3873.patch
>
>
> Currently *pendingApplications* in LeafQueue is using 
> {{applicationComparator}} from CapacityScheduler. This can be changed and 
> pendingApplications can use the OrderingPolicy configured in Queue level 
> (Fifo/Fair as configured). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)