[ 
https://issues.apache.org/jira/browse/YARN-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647045#comment-14647045
 ] 

Arun Suresh commented on YARN-3920:
-----------------------------------

Thanks for the patch [~adhoot],

The patch looks pretty straight forward to me and the test case looks good.
My only minor comment is, Maybe we can expose this as an absolute value, rather 
than a ratio and the {{isReservable()}} function will just take 
min(ReservationThreshold, MaxCapability). I am ok either way though

+1 pending above decision

> FairScheduler Reserving a node for a container should be configurable to 
> allow it used only for large containers
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3920
>                 URL: https://issues.apache.org/jira/browse/YARN-3920
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: yARN-3920.001.patch
>
>
> Reserving a node for a container was designed for preventing large containers 
> from starvation from small requests that keep getting into a node. Today we 
> let this be used even for a small container request. This has a huge impact 
> on scheduling since we block other scheduling requests until that reservation 
> is fulfilled. We should make this configurable so its impact can be minimized 
> by limiting it for large container requests as originally intended. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to