[
https://issues.apache.org/jira/browse/YARN-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647984#comment-14647984
]
Wangda Tan commented on YARN-3887:
----------------------------------
[~sunilg], I took a quick look at the patch, some comments:
- I think you should acquire synchronized lock of LeafQueue when reordering
schedulableEntity.
- SchedulerApplication / SchedulerApplicationAttempt.priority should be
volatile, please let me know if you think it's not necessary.
- Have you considered the case when SchedulerApplicationAttempt is not created?
If you allow edit SchedulerApplication.priority alone (When SchedulerAttempt is
not created), you may need to consider one race condition is:
SchedulerApplication changing priority and creating SchedulerAttempt happen
together, which may need to acquire CapacityScheduler lock.
> Support for changing Application priority during runtime
> --------------------------------------------------------
>
> Key: YARN-3887
> URL: https://issues.apache.org/jira/browse/YARN-3887
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler, resourcemanager
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: 0001-YARN-3887.patch, 0002-YARN-3887.patch,
> 0003-YARN-3887.patch
>
>
> After YARN-2003, adding support to change priority of an application after
> submission. This ticket will handle the server side implementation for same.
> A new RMAppEvent will be created to handle this, and will be common for all
> schedulers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
