[
https://issues.apache.org/jira/browse/YARN-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648969#comment-14648969
]
Rohith Sharma K S commented on YARN-3887:
-----------------------------------------
[~sunilg] thanks for updating patch
One comment
# The below code should not be synchronized. If we have synchronized, then
there is very high chance of deadlock. The locking order should be always from
{{stateMachine --> RMStateStore}} but below code locks in {{RMStateStore -->
stateMachine --> RMStateStore}} which causes deadlock. For more discussion
refer YARN-2946
{code}
+ public synchronized void updateApplicationStateSynchronously(
+ ApplicationStateData appState) {
+ handleStoreEvent(new RMStateUpdateAppEvent(appState));
+ }
{code}
> Support for changing Application priority during runtime
> --------------------------------------------------------
>
> Key: YARN-3887
> URL: https://issues.apache.org/jira/browse/YARN-3887
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler, resourcemanager
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: 0001-YARN-3887.patch, 0002-YARN-3887.patch,
> 0003-YARN-3887.patch, 0004-YARN-3887.patch
>
>
> After YARN-2003, adding support to change priority of an application after
> submission. This ticket will handle the server side implementation for same.
> A new RMAppEvent will be created to handle this, and will be common for all
> schedulers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)