Naganarasimha G R commented on YARN-3045:

Thanks [~sjlee0], for clarifying and describing ur comment, but had some queries
bq.  Note that the user of those two methods is really TimelineCollector. I 
don't think we'd be exposing flush() to TimelineClient. 
Sorry was not able to completely get it. Are you referring to TimelineClient's 
putEntities & putEntitiesAsync ? or 
TimelineWriter's write & flush ? if its later, apart from RM most of the 
entities and events of NM and application go through TimelineClient > 
TimelineCollector . So there should be some way for NM and Client App(AM) to 
inform to flush the data right?

bq. The synchronous nature of the writes would be expressed differently on 
You mean  TimelineClient's putEntities will be ensuring of calling flush ? if 
so some other jira will be handling this ?

bq. These are really events that belong to YARN applications, and I don't see 
why they shouldn't be part of the YARN application entities. 
But some of them related to localization i feel is related to ContainerEntity 
right? hope the approach captured by me is fine ?

> [Event producers] Implement NM writing container lifecycle events to ATS
> ------------------------------------------------------------------------
>                 Key: YARN-3045
>                 URL: https://issues.apache.org/jira/browse/YARN-3045
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3045-YARN-2928.002.patch, 
> YARN-3045-YARN-2928.003.patch, YARN-3045-YARN-2928.004.patch, 
> YARN-3045-YARN-2928.005.patch, YARN-3045-YARN-2928.006.patch, 
> YARN-3045.20150420-1.patch
> Per design in YARN-2928, implement NM writing container lifecycle events and 
> container system metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to