Subru Krishnan commented on YARN-2884:

Thanks [~kishorch] for fixing the test patch warnings and addressing my 
feedback. The latest patch looks mostly good, some minor comments:
   * Since its a new service, can we use slf4j for logging.
   * Can we rename *YarnServerUtils* --> *YarnServerSecurityUtils* and update 
Javadocs accordingly as it has utility methods related to security only.
   * Can we reuse _YarnServerUtils::selectAMRMTokenIdentifier_ or 
_AMRMTokenSelector_ for _AMRMProxyService::getFirstAMRMToken_ as they seem to 
be doing very similar functions.
    * A few public(& protected) methods have Javadoc missing, it'll be great if 
you add for those. 

> Proxying all AM-RM communications
> ---------------------------------
>                 Key: YARN-2884
>                 URL: https://issues.apache.org/jira/browse/YARN-2884
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Kishore Chaliparambil
>         Attachments: YARN-2884-V1.patch, YARN-2884-V2.patch, 
> YARN-2884-V3.patch, YARN-2884-V4.patch, YARN-2884-V5.patch, 
> YARN-2884-V6.patch, YARN-2884-V7.patch
> We introduce the notion of an RMProxy, running on each node (or once per 
> rack). Upon start the AM is forced (via tokens and configuration) to direct 
> all its requests to a new services running on the NM that provide a proxy to 
> the central RM. 
> This give us a place to:
> 1) perform distributed scheduling decisions
> 2) throttling mis-behaving AMs
> 3) mask the access to a federation of RMs

This message was sent by Atlassian JIRA

Reply via email to