Jian He commented on YARN-2884:

thanks [~kishorch] and [~subru],  few comments on my side
thanks @kishore cha a few comments:
- why use containerTokenMasterKeyId for the AMRMTokenIdentifier keyId?
    int masterKeyId = containerTokenIdentifierForKey.getMasterKeyId();
    AMRMTokenIdentifier tokenId =
        new AMRMTokenIdentifier(appAttemptId, masterKeyId);
-  I think we can catch the ApplicationEventType#FINISH_APPLICATION to catch 
the application finished signal ?
        new ContainerEventHandler());
- Today,the AMRMToken will be re-issued periodically, client on receiving a new 
token will updates its own ugi with the new token (see 
AMRMClientImpl#updateAMRMToken), the AMRMTokenProxyService may need to do the 
same if it gets a new token from RM.
- AsynCallback.java file seems not used anywhere

> Proxying all AM-RM communications
> ---------------------------------
>                 Key: YARN-2884
>                 URL: https://issues.apache.org/jira/browse/YARN-2884
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Kishore Chaliparambil
>         Attachments: YARN-2884-V1.patch, YARN-2884-V2.patch, 
> YARN-2884-V3.patch, YARN-2884-V4.patch, YARN-2884-V5.patch, 
> YARN-2884-V6.patch, YARN-2884-V7.patch, YARN-2884-V8.patch
> We introduce the notion of an RMProxy, running on each node (or once per 
> rack). Upon start the AM is forced (via tokens and configuration) to direct 
> all its requests to a new services running on the NM that provide a proxy to 
> the central RM. 
> This give us a place to:
> 1) perform distributed scheduling decisions
> 2) throttling mis-behaving AMs
> 3) mask the access to a federation of RMs

This message was sent by Atlassian JIRA

Reply via email to