[
https://issues.apache.org/jira/browse/YARN-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662172#comment-14662172
]
Wangda Tan commented on YARN-2923:
----------------------------------
Hi Naga,
bq. PreviousNodeLabels will be reset every time if we do a fetch. (To avoid
handle same node labels as much as possible)
I cannot remember what I meant previously, so please ignore it.
bq. Don't do check if new fetched node label is as same as previousNodeLabels.
(Also, avoid handle same node label)
Re-read your patch, it should work properly, ignore this comment also.
bq. Don't reset node label if fetched node label is incorrect. (This should be
a part of error handling, we should treat it's a error to be avoided instead of
force reset it)
What I meant for this one is, in your patch, it reset node label for invalid
labels to empty-string-set. I think this is discussible. When a node generated
a wrong set of labels (and previous labels are valid), I prefer to keep it
unchanged instead of reset labels to empty. IAW, reset invalid labels to empty
and send to RM seems a little over-kill to me.
{code}
previousNodeLabels = nodeLabelsForHeartbeat;
nodeLabelsForHeartbeat =
CommonNodeLabelsManager.EMPTY_NODELABEL_SET;
invalidLabels = true;
{code}
This is not conflict with
https://issues.apache.org/jira/browse/YARN-2495?focusedCommentId=14358109&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14358109.
The comment in YARN-2495 is majorly for registeration, set to empty is correct
when we don't have a previously correct labels.
bq. Hmm agree on this but approach i felt we can have a inner class like
NMDistributedNodeLabelsHandler...
It should be good.
Thanks,
Wangda
> Support configuration based NodeLabelsProvider Service in Distributed Node
> Label Configuration Setup
> -----------------------------------------------------------------------------------------------------
>
> Key: YARN-2923
> URL: https://issues.apache.org/jira/browse/YARN-2923
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Fix For: 2.8.0
>
> Attachments: YARN-2923.20141204-1.patch, YARN-2923.20141210-1.patch,
> YARN-2923.20150328-1.patch, YARN-2923.20150404-1.patch,
> YARN-2923.20150517-1.patch
>
>
> As part of Distributed Node Labels configuration we need to support Node
> labels to be configured in Yarn-site.xml. And on modification of Node Labels
> configuration in yarn-site.xml, NM should be able to get modified Node labels
> from this NodeLabelsprovider service without NM restart
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
