Naganarasimha G R commented on YARN-2923:

Hi [~leftnoteasy],
Thanks for the comments, 
bq.  I prefer to keep it unchanged instead of reset labels to empty. IAW, reset 
invalid labels to empty and send to RM seems a little over-kill to me.
Yes this is debatable topic when we consider the partition labels then seems 
like not required but when it comes to constraints i think it would be required 
as per the earlier examples given. One thought i had was, may be for 
constraints we can group them and one of the value in the group can be given 
and on invalid labels, labels related to that group can be removed. As there is 
one more jira (YARN-3506) for error handling thought of further discussing this 
topic there and as far as this jira i will send nulls on NM Labels validation 
Also have handled as discussed for {{NMDistributedNodeLabelsHandler}}.
{{TestYarnConfigurationFields}} test case failure has been corrected and 
{{TestRackResolver}} seems to be not related to this jira and locally its 
Checkstyle issue is related to the number of lines in YarnConfiguration,

> Support configuration based NodeLabelsProvider Service in Distributed Node 
> Label Configuration Setup 
> -----------------------------------------------------------------------------------------------------
>                 Key: YARN-2923
>                 URL: https://issues.apache.org/jira/browse/YARN-2923
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>             Fix For: 2.8.0
>         Attachments: YARN-2923.20141204-1.patch, YARN-2923.20141210-1.patch, 
> YARN-2923.20150328-1.patch, YARN-2923.20150404-1.patch, 
> YARN-2923.20150517-1.patch, YARN-2923.20150817-1.patch
> As part of Distributed Node Labels configuration we need to support Node 
> labels to be configured in Yarn-site.xml. And on modification of Node Labels 
> configuration in yarn-site.xml, NM should be able to get modified Node labels 
> from this NodeLabelsprovider service without NM restart

This message was sent by Atlassian JIRA

Reply via email to