[ 
https://issues.apache.org/jira/browse/YARN-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14669887#comment-14669887
 ] 

Sunil G commented on YARN-3250:
-------------------------------

HI [~rohithsharma]
Thank you for sharing the patch. Overall patch looks good. 

Few comments:
1. NumberFormatException will be thrown from {{conf.getInt()}}. So 
{{getClusterMaxPriority()}} can be updated by throwing this exception, and can 
be given back to client side
2. Could we have a test case to see priority is updated from config. As we do 
not have a getter to see this change from client side, cud we verify it in 
server side itself.



> Support admin cli interface in for Application Priority
> -------------------------------------------------------
>
>                 Key: YARN-3250
>                 URL: https://issues.apache.org/jira/browse/YARN-3250
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sunil G
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-3250-V1.patch
>
>
> Current Application Priority Manager supports only configuration via file. 
> To support runtime configurations for admin cli and REST, a common management 
> interface has to be added which can be shared with NodeLabelsManager. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to