[
https://issues.apache.org/jira/browse/YARN-3906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680920#comment-14680920
]
Li Lu commented on YARN-3906:
-----------------------------
Latest patch LGTM. While it appears possible to remove some code duplication in
parseEntity in HBase reader, I realized that we're limited by the static types
of our enums. I'm OK with move forward now to enable more aggregation patches,
and we can do cosmetic fix later.
However, one precaution is on the event column qualifiers. I notice we're still
following the old way to convert event column qualifiers into strings (like
{{String valueKey = Bytes.toString(compoundColumnQualifierBytes);}} in
TestHBaseTimelineWriterImpl). This is totally fine in the current patch, but we
need to fix them in YARN-4025.
> split the application table from the entity table
> -------------------------------------------------
>
> Key: YARN-3906
> URL: https://issues.apache.org/jira/browse/YARN-3906
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Sangjin Lee
> Assignee: Sangjin Lee
> Attachments: YARN-3906-YARN-2928.001.patch,
> YARN-3906-YARN-2928.002.patch, YARN-3906-YARN-2928.003.patch,
> YARN-3906-YARN-2928.004.patch, YARN-3906-YARN-2928.005.patch,
> YARN-3906-YARN-2928.006.patch, YARN-3906-YARN-2928.007.patch
>
>
> Per discussions on YARN-3815, we need to split the application entities from
> the main entity table into its own table (application).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
